Intensity prints the picture, it does not lay it out

Turning the shading down changed the size of every word on screen. On a phone at
390x844 the upscale went from 1.5 to 2, on a 1440x900 laptop from 4.5 to 3, and
on a 1920x1080 one from 3 to 4 — and the chrome is sized in layout units times
that upscale, so a third was added to or taken off every button, every label and
every rule in the DOM. Five of twelve ordinary window sizes did it.

The cause is one argument. The ladder of crisp upscales is density*k/dpr, so it
is cut differently for each density: at dpr 2 the standard density offers 1.5, 3
and 4.5, and the low one offers 1, 2, 3 and 4. `choose` was handed whichever
density the setting was on, so a control over how the picture is *printed* was
picking which layout the app got.

It is handed the standard density now, always. The ladder stops moving, and the
setting does what its label says. The default path is untouched — the standard
density is what it was already choosing from — so this only ever moves the low
setting, and it moves it onto the layout the app was going to have anyway.

What is left: at an upscale where scale*dpr is odd, 1.5 and 4.5 on a dpr 2
screen, a low-density buffer pixel now covers one and a half device pixels
rather than a whole number of them, so the ground's ruling goes slightly uneven
there. That is a shading artifact in the setting that asks for coarser shading,
which is the right place for it to land, and it is a much smaller thing than
relaying out the app.

commit

7906417dea964b0b722c4cfd6847888f9cb8a399

parent

02af01d6be57a4f79795f82536d5b4c98b4872d5

author

Dami <dami.etoile@gmail.com>