cat / 012
clone

a spreadsheet for the terminal: lotus 1-2-3 looks, google sheets keys and formulas, one go binary

Add make check: gofmt, vet, lint, tests, oracle and e2e before a push

Dami committed 23f0bf0
commit
23f0bf06ca18390900d605424164e381bd540711
parent
dd947e9ce56da82e1e889fa67af89cb36c7a9a15
author
Dami <dami.etoile@gmail.com>
3 files changed, +14 -2
MMakefile13++++++++++++-
MROADMAP.md2+-
Mdocs/testing.md1+
M Makefile +12 -1
@@ -7,7 +7,7 @@ GHOSTTY_SRC := $(DEPS)/ghostty-src
77 GHOSTTY_OUT := $(DEPS)/ghostty88 GHOSTTY_STAMP := $(GHOSTTY_OUT)/.built-$(GHOSTTY_COMMIT)99 10-.PHONY: lint build run test fuzz e2e screens oracle demos libghostty clean stress stress-data stress-report obs-up obs-down obs-status stress-load stress-e2e10+.PHONY: check lint build run test fuzz e2e screens oracle demos libghostty clean stress stress-data stress-report obs-up obs-down obs-status stress-load stress-e2e1111 1212 build:1313 CGO_ENABLED=0 go build -o bin/012 ./cmd/012
@@ -18,6 +18,17 @@ run: build
1818 test:1919 go test ./...2020 21+# Everything that must pass before a push: formatting, vet (also with the22+# stress benchmarks), shape limits, unit tests, the excelize oracle and the23+# end-to-end tests in libghostty.24+check:25+ @test -z "$$(gofmt -l cmd internal demos e2e oracle)" || { gofmt -l cmd internal demos e2e oracle; echo "gofmt: files above need formatting"; exit 1; }26+ go vet -tags stress ./...27+ $(MAKE) lint28+ go test ./...29+ $(MAKE) oracle30+ $(MAKE) e2e31+2132 # Code shape limits: cognitive complexity and file length.2233 lint:2334 go vet ./...
M ROADMAP.md +1 -1
@@ -148,7 +148,7 @@ work left open. Sizes: S (a day or two), M (about a week), L (weeks).
148148 | Item | Size |149149 |---|---|150150 | Version tags and release notes; prebuilt binaries attached to tags (built locally, since the repo is hosting only) | S |151-| `make check`: vet, lint, tests, oracle, e2e in one target, run before every push | S |151+| `make check`: vet, lint, tests, oracle, e2e in one target, run before every push. Done | S |152152 | `make stress-report` thresholds that flag regressions over a set percentage against the last release | S |153153 | Grafana: a trace panel for the nested spans | S |154154 | Accessibility: a high-contrast theme, and every state readable without color (already a UX rule; audit it) | S |
M docs/testing.md +1 -0
@@ -1,6 +1,7 @@
11 # Testing22 33 ```sh4+make check # all of the below that must pass before a push: gofmt, vet, lint, test, oracle, e2e45 make lint # go vet, cognitive complexity at most 25, Go files at most 500 lines56 make test # engine, file formats and UI unit tests67 make fuzz # fuzz the formula parser and the CSV, .wk1 and XLSX readers